Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly simpler scrollTo logic for foldable components. #7345

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Slightly simpler scrollTo logic for foldable components. #7345

merged 1 commit into from
Jan 5, 2024

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Jan 2, 2024

@isoos isoos requested a review from sigurdm January 2, 2024 16:59
@sigurdm
Copy link
Contributor

sigurdm commented Jan 5, 2024

Could you put this on staging?

@isoos
Copy link
Collaborator Author

isoos commented Jan 5, 2024

Could you put this on staging?

Done.

@isoos isoos merged commit 21fce19 into dart-lang:master Jan 5, 2024
31 checks passed
@isoos isoos deleted the scrollto branch January 5, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use scrollIntoView instead of custom scroll logic for foldable components.
2 participants
@isoos @sigurdm